Read vmin_plot and vmax_plot #406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Converted to draft since there are some bugs |
Collaborator
Author
|
I'm going to close this and redo it from scratch, since it's easier than fixing this after #404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the fact that vmin_plot and vmax_plot were often not read by the driver, especially if they were written in data_proc in the plots, which was inconsistent.
There is, however, one breaking change: spatial_dist was reading vmax and vmin. That was an inconsistency, so I believe that doing this breaking change is justifiable in this case.
Cheers
Pablo